search

plone / plone.recipe.zope2instance

zc.buildout recipe to setup and configure a Zope 2 instance.
https://pypi.org/project/plone.recipe.zope2instance
6 stars 23 forks source link

Add the ability to specify a custom WSGI configuration file #91

Closed dataflake closed 5 years ago

dataflake commented 5 years ago

fixes #90

The feature "overloads" the wsgi configuration key and allows you to pass something other than the normal "on/off" types of flags. If it's not recognized as such a flag the value is considered to be a path to a WSGI configuration .ini file.

Unlike the built-in waitress support, this requires the user to provide that configuration file himself. The recipe simply can't know other WSGI server's configuration options.

This makes it really easy to just pull the WSGI server egg into the eggs list and generate a runner that uses a different WSGI server.

mister-roboto commented 5 years ago

@dataflake thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

dataflake commented 5 years ago

@jenkins-plone-org please run jobs