search

plone / plone.recipe.zope2instance

zc.buildout recipe to setup and configure a Zope 2 instance.
https://pypi.org/project/plone.recipe.zope2instance
6 stars 23 forks source link

Add ability to turn off `zodb-temporary-storage` to prevent Zope 4 breakage #93

Closed dataflake closed 5 years ago

dataflake commented 5 years ago

Fixes #87

I have changed the allowed input values for zodb-temporary-storage so it can be turned off explicitly by passing something like off or false. The existing semantic of "add this but leave it empty" is non-obvious and odd.

I have called this a bug because it breaks basic Zope 4 startup right now.

My original plan of trying to peek into the resolved set of requirements and find Products.TemporaryFolder seemed too hard in this place of the code.

I want to use this flag (and the changes from my previous PRs) in my Zope installation documentation rewrite where I am featuring plone.recipe.zope2instance as the most convenient way of installing and configuring Zope, so I would like to ask for a release from you when this is merged.

See https://zope.readthedocs.io/en/latest/INSTALL.html and https://zope.readthedocs.io/en/latest/operation.html for the current documentation status.

mister-roboto commented 5 years ago

@dataflake thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

dataflake commented 5 years ago

@jenkins-plone-org please run jobs