search

plone / plone.recipe.zope2instance

zc.buildout recipe to setup and configure a Zope 2 instance.
https://pypi.org/project/plone.recipe.zope2instance
7 stars 23 forks source link

Enable socket reuse to prevent startup errors when running in foreground #94

Closed dataflake closed 5 years ago

dataflake commented 5 years ago

Fixes #86

With this fix I cannot reproduce the startup errors due to still-existing sockets anymore in manual testing under both Python 2.7 and 3.7

Applying socket flags inside ctl.serve_paste didn't help here, and neither did attempting to call shutdown on the socket object before the close call in the finally clause of serve_paste. Applying the reuse setting through waitress' own asyncore dispatcher worked.

mister-roboto commented 5 years ago

@dataflake thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

dataflake commented 5 years ago

@jenkins-plone-org please run jobs