search

plone / plone.recipe.zope2instance

zc.buildout recipe to setup and configure a Zope 2 instance.
https://pypi.org/project/plone.recipe.zope2instance
6 stars 23 forks source link

Remove duplicate word. #99

Closed jugmac00 closed 5 years ago

mister-roboto commented 5 years ago

@jugmac00 you need to sign the Plone Contributor Agreement in order to merge this pull request.

Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html

mister-roboto commented 5 years ago

@jugmac00 thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

jugmac00 commented 5 years ago

@jugmac00 you need to sign the Plone Contributor Agreement in order to merge this pull request.

Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html

I'll sign it next Monday. Got no printer at home :-(

jugmac00 commented 5 years ago

I submitted/sent the contributor's agreement today.

The build currently fails due to pip-gate, cf https://github.com/pypa/pip/issues/6434 https://discuss.python.org/t/pip-19-1-and-installing-in-editable-mode-with-pyproject-toml/1553/39

I'd suggest to wait a couple of days until the pip maintainers offer a proper solution.

mauritsvanrees commented 5 years ago

I have merged PR #102 which fixes the Travis problem. Can you rebase your branch on master or merge the master changes and try again?

jugmac00 commented 5 years ago

@mauritsvanrees Thanks for merging!

And yes, I know it was not strictly necessary, as similar rules apply for contributing to Zope - which I do since last year's Zope 4 Welcome Sprint and especially since Saltlabs sprint – Zope and Plone together.

I inherited quite a big Zope installation which happens to use a couple of Plone packages, including this recipe. So it certainly does not hurt to have the agreement signed. You'll never know what comes :-)