search

plone / plone.restapi

RESTful API for Plone.
http://plonerestapi.readthedocs.org/
84 stars 75 forks source link

Fixed tests in combination with newer plone.app.z3cform. #1603

Closed mauritsvanrees closed 1 year ago

mauritsvanrees commented 1 year ago

See https://github.com/plone/plone.app.z3cform/pull/162

Instead of

<input id="__ac_password" name="__ac_password"

we get:

<input class="form-control password-widget required password-field" id="__ac_password" name="__ac_password" type="password" />
mister-roboto commented 1 year ago

@mauritsvanrees thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

netlify[bot] commented 1 year ago

Deploy Preview for plone-restapi canceled.

Name Link
Latest commit 66807b3ea23b14c6897ed32cba63f89c4bb124b7
Latest deploy log https://app.netlify.com/sites/plone-restapi/deploys/641a467ac0f8110008b4a043
mauritsvanrees commented 1 year ago

@jenkins-plone-org please run jobs