fix deprecation warnings and proper isort

[jensens]

• fix a bunch of deprecation warnings
• applied proper isort (I did not add this for now to CI, because I hope for plone/meta here - cc @gforcada)
• some unclosed file issues in tests fixed using context-manager.
• other minor adjustments

[mister-roboto]

@jensens thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

[netlify[bot]]

✅ Deploy Preview for plone-restapi canceled.

Name	Link
🔨 Latest commit	2f230175f64834501dca2b8bcfc9d15a42f1956f
🔍 Latest deploy log	https://app.netlify.com/sites/plone-restapi/deploys/6427eeb9f7155b0007497dfa

[jensens]

@jenkins-plone-org please run jobs

[jensens]

@jenkins-plone-org please run jobs

[jensens]

I have no idea why only Tests / build (3.9, 6.0) (push) fails. And there in Sphinx only. Another question is why we need Sphinx runs in all Python version.

[mauritsvanrees]

I started a new run on master, but it fails in the same way on 3.9:

cd ./docs/source/ && /home/runner/work/plone.restapi/plone.restapi/bin/sphinx-build -b html -d ../_build//doctrees  . ../_build//html
Running Sphinx v4.5.0
making output directory... done

Extension error:
Could not import extension sphinx_book_theme (exception: cannot import name '_get_theme_options' from 'pydata_sphinx_theme' (/home/runner/work/plone.restapi/plone.restapi/lib/python3.9/site-packages/pydata_sphinx_theme/__init__.py))

[mauritsvanrees]

The 3.9 tests should be fixed with PR #1609, awaiting review.

[jensens]

@jenkins-plone-org please run jobs

[davisagli]

@jensens You merged with a broken build though; now master is broken.

[davisagli]

@jensens Fixed in https://github.com/plone/plone.restapi/commit/4d97f6d70ffb6f514b3b5b478d5d8c8c90071cf0

[jensens]

Merged broken? I set it to auto merge with green tests. It seems this does not work as expected. Thanks for fixing it.

[davisagli]

@jensens Auto merge will merge once all of the required checks are green, even if there are other checks which are red. (Required checks are configured in the branch protection settings)

[jensens]

@davisagli damn, I thought it needs all green. We need to review the settings, or switch off the auto merge.

[davisagli]

@jensens I turned off automerge for plone.restapi until we have a chance to set appropriate required checks.