search

plone / plone.restapi

RESTful API for Plone.
http://plonerestapi.readthedocs.org/
84 stars 75 forks source link

Fix param handling in querystringsearch GET #1622

Closed davisagli closed 1 year ago

davisagli commented 1 year ago

Copy the params from the querystring into the request body, because there are too many bits of code that expect to find things there.

Adjusted the test to confirm pagination works.

Fixes #1621

mister-roboto commented 1 year ago

@davisagli thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

netlify[bot] commented 1 year ago

Deploy Preview for plone-restapi canceled.

Name Link
Latest commit 5905a7d02b1b1615269f00f46133abad17adfd20
Latest deploy log https://app.netlify.com/sites/plone-restapi/deploys/643d829711557a0008be4e3e
davisagli commented 1 year ago

@jenkins-plone-org please run jobs