plone / plone.restapi

RESTful API for Plone.
http://plonerestapi.readthedocs.org/
84 stars 73 forks source link

Add items_total to linkintegrity endpoint #1636

Closed davisagli closed 10 months ago

davisagli commented 1 year ago

This will be used by the linkintegrity check when an object is deleted, to add the number of contained items that will be deleted.

It is a backwards-incompatible change, because current versions of volto expect that the result will include items only if there were some linkintegrity breaches.

Also fixes #1511 by adding the missing documentation for this endpoint

mister-roboto commented 1 year ago

@davisagli thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

netlify[bot] commented 1 year ago

Deploy Preview for plone-restapi ready!

Name Link
Latest commit 37c2452dd882f07f2e000682ae444dcd697c1fe2
Latest deploy log https://app.netlify.com/sites/plone-restapi/deploys/64e7b0bdfcb8c100081f6e4c
Deploy Preview https://deploy-preview-1636--plone-restapi.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

davisagli commented 1 year ago

@jenkins-plone-org please run jobs

davisagli commented 1 year ago

@stevepiercy Could you please review the doc updates here?

tisto commented 11 months ago

@davisagli am I correct assuming that we just add an "items_total" attribute to the response here? Then I'd say we can merge that and release it as a feature release.

tisto commented 11 months ago

@jenkins-plone-org please run jobs

tisto commented 10 months ago

@jenkins-plone-org please run jobs

tisto commented 10 months ago

@jenkins-plone-org please run jobs

tisto commented 10 months ago

@jenkins-plone-org please run jobs