search

plone / plone.restapi

RESTful API for Plone.
http://plonerestapi.readthedocs.org/
84 stars 73 forks source link

Use plone.app.multilingual conditionally #1643

Closed folix-01 closed 1 year ago

mister-roboto commented 1 year ago

@folix-01 thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

netlify[bot] commented 1 year ago

Deploy Preview for plone-restapi canceled.

Name Link
Latest commit 7431d0fddf61c990cc34b299b7ae1fc2390a03d9
Latest deploy log https://app.netlify.com/sites/plone-restapi/deploys/64aecd1fb8d04e0008463ae1
jensens commented 1 year ago

Why does it touch many unrelated files?

erral commented 1 year ago

Why is this needed?

plone.restapi master is already Plone 5.x only which already includes p.a.multilingual as a dependency.

folix-01 commented 1 year ago

Why does it touch many unrelated files?

Because of black I think

folix-01 commented 1 year ago

Why is this needed?

plone.restapi master is already Plone 5.x only which already includes p.a.multilingual as a dependency.

Because we need to remove il from the Products.CMFPlone

jensens commented 1 year ago

We remove it as a dep of CMFPlone and add it as a dep on Plone. Thus it becomes a core-addon. Architecture wise this is favorable. At the end, for the user, nothing changed.

jensens commented 1 year ago

@jenkins-plone-org please run jobs