search

plone / plone.restapi

RESTful API for Plone.
http://plonerestapi.readthedocs.org/
84 stars 73 forks source link

Fix possible startup error by loading plone.app.contentrules zcml #1645

Closed mauritsvanrees closed 1 year ago

mauritsvanrees commented 1 year ago

Also: only load code related to contentrules when this package is available. Fixes https://github.com/plone/plone.restapi/issues/1644

I have a small doubt where some of these conditions should be on plone.contentrules instead of plone.app.contentrules. But I guess this is one of those split packages where you either have none or both. I doubt that anyone has written an own implementation on top of plone.contentrules that actually works with the current restapi code around it. I think we do not need to worry.

mister-roboto commented 1 year ago

@mauritsvanrees thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

netlify[bot] commented 1 year ago

Deploy Preview for plone-restapi canceled.

Name Link
Latest commit 04d7b724cf8744a4e98d020233d246db855312df
Latest deploy log https://app.netlify.com/sites/plone-restapi/deploys/6471f59eb204f10008cc8789
mauritsvanrees commented 1 year ago

@jenkins-plone-org please run jobs