plone / plone.restapi

RESTful API for Plone.
http://plonerestapi.readthedocs.org/
84 stars 75 forks source link

Fix timezone handling in history endpoint and tests #1647

Closed davisagli closed 1 year ago

davisagli commented 1 year ago

Fixes #1617

Also fixes the StaticTime helper used in tests to specify that the fake times used in tests are UTC, which should help with the problem where the times produced in tests are different depending on the local timezone of the machine where they run.

(This causes many example responses to be updated to add +00:00 to the serialized datetimes. This better matches the actual serialized datetimes that are produced when not running tests.)

mister-roboto commented 1 year ago

@davisagli thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

netlify[bot] commented 1 year ago

Deploy Preview for plone-restapi canceled.

Name Link
Latest commit 28e9cb5dc7296e57ff5bcab4f3f56bd49332f09b
Latest deploy log https://app.netlify.com/sites/plone-restapi/deploys/64b1a7998890520008e7352b
davisagli commented 1 year ago

@jenkins-plone-org please run jobs

jensens commented 1 year ago

@jenkins-plone-org please run jobs

davisagli commented 1 year ago

@jenkins-plone-org please run jobs