search

plone / plone.restapi

RESTful API for Plone.
http://plonerestapi.readthedocs.org/
84 stars 75 forks source link

Centralize logic for finding all blocks #1648

Closed davisagli closed 1 year ago

davisagli commented 1 year ago

Add a visit_blocks util which can be extended using IBlockVisitor subscribers.

To do:

This should also be useful for https://github.com/plone/plone.volto/pull/121

netlify[bot] commented 1 year ago

Deploy Preview for plone-restapi ready!

Name Link
Latest commit e26eb46811da233850721cd73dc52ed8fd97f6a3
Latest deploy log https://app.netlify.com/sites/plone-restapi/deploys/649a0ee04906e900082c7d92
Deploy Preview https://deploy-preview-1648--plone-restapi.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mister-roboto commented 1 year ago

@davisagli thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

davisagli commented 1 year ago

@jenkins-plone-org please run jobs

davisagli commented 1 year ago

@plone/volto-team This is some refactoring to reduce code duplication and provide a standard way to get all blocks (including blocks contained inside another block). I think it is backwards-compatible; do you see any problem?

davisagli commented 1 year ago

@jenkins-plone-org please run jobs