plone / plone.restapi

RESTful API for Plone.
http://plonerestapi.readthedocs.org/
84 stars 73 forks source link

handle suffix with not traversable objects #1649

Closed cekk closed 1 year ago

cekk commented 1 year ago

The use-case is a link that ends with "/@@download/file" for example (http://my-site.com/foo/@@download/file).

Previous implementation can't get the object and returned not modified url, because /file is not traversable with the object traverser, but only with the browser traverser.

Current implementation return "resolveuid/123456/@@download/file"

netlify[bot] commented 1 year ago

Deploy Preview for plone-restapi ready!

Name Link
Latest commit 015a3c18178665500d4735a9cd0046ef21ebc914
Latest deploy log https://app.netlify.com/sites/plone-restapi/deploys/64991eafa23c7f0008fd3661
Deploy Preview https://deploy-preview-1649--plone-restapi.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

mister-roboto commented 1 year ago

@cekk thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

mamico commented 1 year ago

@jenkins-plone-org please run jobs

davisagli commented 1 year ago

@jenkins-plone-org please run jobs

davisagli commented 1 year ago

@jenkins-plone-org please run jobs