Closed Akshat2Jain closed 1 year ago
Name | Link |
---|---|
Latest commit | 200c95728807d83fe75ce962cdc17f3597f88f88 |
Latest deploy log | https://app.netlify.com/sites/plone-restapi/deploys/648bfc35f8f9e0000855872e |
@Akshat2Jain thanks for creating this Pull Request and helping to improve Plone!
TL;DR: Finish pushing changes, pass all other checks, then paste a comment:
@jenkins-plone-org please run jobs
To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.
Happy hacking!
Hey @wesleybl, I have made the changes. Can you review it.
Now I think, Its good to go @wesleybl .
@wesleybl Can you review it again? Thanks.
@Akshat2Jain by having several commits, I suspect that you were making the commits through the github website. I recommend that next time, you make a clone of the repository and put several files in one commit. That way we won't have multiple commits.
Thanks for the contribution!
@Akshat2Jain by having several commits, I suspect that you were making the commits through the github website. I recommend that next time, you make a clone of the repository and put several files in one commit. That way we won't have multiple commits.
Yeah, I will keep that in mind! Thank You
Description
This pr aims to allow tests to run on PRs from forks
How
pull_request
in on in all.yml
files here:if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name != github.event.pull_request.base.repo.full_name
in all jobs.This pr is reated to isse #1656