plone / plone.restapi

RESTful API for Plone.
http://plonerestapi.readthedocs.org/
84 stars 75 forks source link

Allow PRs from forks to run tests #1659

Closed Akshat2Jain closed 1 year ago

Akshat2Jain commented 1 year ago

Description

This pr aims to allow tests to run on PRs from forks

How

This pr is reated to isse #1656

netlify[bot] commented 1 year ago

Deploy Preview for plone-restapi canceled.

Name Link
Latest commit 200c95728807d83fe75ce962cdc17f3597f88f88
Latest deploy log https://app.netlify.com/sites/plone-restapi/deploys/648bfc35f8f9e0000855872e
mister-roboto commented 1 year ago

@Akshat2Jain thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

Akshat2Jain commented 1 year ago

Hey @wesleybl, I have made the changes. Can you review it.

Akshat2Jain commented 1 year ago

Now I think, Its good to go @wesleybl .

Akshat2Jain commented 1 year ago

@wesleybl Can you review it again? Thanks.

wesleybl commented 1 year ago

@Akshat2Jain by having several commits, I suspect that you were making the commits through the github website. I recommend that next time, you make a clone of the repository and put several files in one commit. That way we won't have multiple commits.

Thanks for the contribution!

Akshat2Jain commented 1 year ago

@Akshat2Jain by having several commits, I suspect that you were making the commits through the github website. I recommend that next time, you make a clone of the repository and put several files in one commit. That way we won't have multiple commits.

Yeah, I will keep that in mind! Thank You