Update makefile - Githubissues

plone / plone.restapi

RESTful API for Plone.

http://plonerestapi.readthedocs.org/

84 stars 73 forks source link

Update makefile #1665

Closed Akshat2Jain closed 1 year ago

Akshat2Jain commented 1 year ago

Description

This PR updates the Makefile to ensure consistent installations of black and click. Currently, the Makefile installs the latest versions, while the CI process installs specific versions mentioned in the versions.cfg file. This PR aligns the installations in the Makefile with the versions specified in the versions.cfg file.

Changes Made

Modified the Makefile to install black and click with the versions mentioned in versions.cfg. OR
Upgraded the installations of black and click to the latest versions mentioned in versions.cfg.

Reason for the Changes

Ensures consistency between local development and the CI environment.
Aligns installations with the versions specified in versions.cfg. OR
Benefits from the latest features and bug fixes available in the upgraded versions.

This is pr is realated to #1655

netlify[bot] commented 1 year ago

Deploy Preview for plone-restapi canceled.

Name	Link
Latest commit	622e7fa5abf0340be0a788a06108849e0e2e736c
Latest deploy log	https://app.netlify.com/sites/plone-restapi/deploys/64a6e5a1a9a9920007f461a4

mister-roboto commented 1 year ago

@Akshat2Jain thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!