search

plone / plone.restapi

RESTful API for Plone.
http://plonerestapi.readthedocs.org/
84 stars 73 forks source link

updated makefile #1666

Closed Akshat2Jain closed 1 year ago

Akshat2Jain commented 1 year ago

Description

This PR updates the Makefile to ensure consistent installations of black and click. Currently, the Makefile installs the latest versions, while the CI process installs specific versions mentioned in the versions.cfg file. This PR aligns the installations in the Makefile with the versions specified in the versions.cfg file.

Changes Made

Reason for the Changes

This is pr is realated to #1655

mister-roboto commented 1 year ago

@Akshat2Jain thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

netlify[bot] commented 1 year ago

Deploy Preview for plone-restapi canceled.

Name Link
Latest commit 5a9689d51cc29e175a837a34a6aea1d023d0be75
Latest deploy log https://app.netlify.com/sites/plone-restapi/deploys/64a7e59e38479f0008bb6a40
Akshat2Jain commented 1 year ago

@wesleybl . Plz check

stevepiercy commented 1 year ago

@Akshat2Jain please add a change log entry.

wesleybl commented 1 year ago

@Akshat2Jain as I said in the other PR, you must keep your fork's master branch equal to the original repository's master branch. When you go to do a PR, you must create a new branch, based on master. You shouldn't commit directly to master. Would you like to try again? can we close this PR?

Akshat2Jain commented 1 year ago

@Akshat2Jain as I said in the other PR, you must keep your fork's master branch equal to the original repository's master branch. When you go to do a PR, you must create a new branch, based on master. You shouldn't commit directly to master. Would you like to try again? can we close this PR?

Sorry for the inconvenience. I will do another pr