search

plone / plone.restapi

RESTful API for Plone.
http://plonerestapi.readthedocs.org/
84 stars 73 forks source link

Fix types expander in root for 5.2 (for non-DX Plone Site Root) #1669

Closed sneridagh closed 11 months ago

sneridagh commented 12 months ago

Related to: https://github.com/plone/volto/pull/4946

The tests failed for 5.2 when trying to use the expander in a non-DX Plone site root.

I updated also the build for 5.2 to latest Plone 5.

netlify[bot] commented 12 months ago

Deploy Preview for plone-restapi canceled.

Name Link
Latest commit 79c39f8e163ce73d9982f55969dd6ccd7eaa73a5
Latest deploy log https://app.netlify.com/sites/plone-restapi/deploys/64b189e448ef9a00084456f5
mister-roboto commented 12 months ago

@sneridagh thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

sneridagh commented 12 months ago

@jenkins-plone-org please run jobs

sneridagh commented 12 months ago

@jenkins-plone-org please run jobs

sneridagh commented 11 months ago

@davisagli whenever you have time, a release with this one and the images serializers would be great! Thanks!