search

plone / plone.restapi

RESTful API for Plone.
http://plonerestapi.readthedocs.org/
84 stars 75 forks source link

Resolve version constraints for black package installation #1671

Closed Akshat2Jain closed 1 year ago

Akshat2Jain commented 1 year ago

This pull request introduces several updates and improvements to the codebase. Here is a summary of the changes:

This Pr is related to the #1668

netlify[bot] commented 1 year ago

Deploy Preview for plone-restapi canceled.

Name Link
Latest commit 9c36b301b0e905441fa44866ba6d219b2cac6c16
Latest deploy log https://app.netlify.com/sites/plone-restapi/deploys/64b1902c128ccc000890b603
mister-roboto commented 1 year ago

@Akshat2Jain thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

Akshat2Jain commented 1 year ago

@wesleybl, Can you review it?

wesleybl commented 1 year ago

Please remove versions.cfg file.

Akshat2Jain commented 1 year ago

@wesleybl, Can you check constraints.txt once, is there something to add?

wesleybl commented 1 year ago

@Akshat2Jain the error gives you a hint. Click Details on the black error in: https://github.com/plone/plone.restapi/pull/1671#partial-pull-merging

Akshat2Jain commented 1 year ago

Flake 8 is failing, Do I have to do the same as black

wesleybl commented 1 year ago

@fredvd @polyester can you please add @Akshat2Jain to the Plone Developers team? He has already done some PR and I think he already understands how it works. This would be easier for him and for those who review. Thanks!

polyester commented 1 year ago

@wesleybl sure, no problem and done.

wesleybl commented 1 year ago

@polyester Thanks!

@Akshat2Jain in the next PR, please create the branch in the original repository.

Akshat2Jain commented 1 year ago

@wesleybl @polyester @fredvd Thank You, guys!