search

plone / plone.restapi

RESTful API for Plone.
http://plonerestapi.readthedocs.org/
84 stars 75 forks source link

Docs: add section to upgrade guide for p.restapi 8 #1689

Closed tisto closed 1 year ago

mister-roboto commented 1 year ago

@tisto thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

netlify[bot] commented 1 year ago

Deploy Preview for plone-restapi ready!

Name Link
Latest commit ac37b2922de9d0f90af4bddc57728d1e8a542850
Latest deploy log https://app.netlify.com/sites/plone-restapi/deploys/64e65ab52464ba0008a8f964
Deploy Preview https://deploy-preview-1689--plone-restapi.netlify.app/upgrade-guide.html
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

stevepiercy commented 1 year ago

In the future, please do not delete deliberate blank lines before headings. They help authors find sections.

Also there are some MyST syntax issues that need to be addressed.

I am also concerned about the deletion of some lines. I don't know whether that was deliberate or accidental.

I'll make a separate PR to resolve these issues, except for the last one, but I wanted to let y'all know.

davisagli commented 1 year ago

Those lines were not deleted. I’m not sure why GitHub is showing them in red but it’s a different red.

On Thu, Aug 24, 2023 at 4:14 AM Steve Piercy @.***> wrote:

In the future, please do not delete deliberate blank lines before headings. They help authors find sections.

Also there are some MyST syntax issues that need to be addressed.

I am also concerned about the deletion of some lines https://github.com/plone/plone.restapi/pull/1689/files#diff-5181575a5b963d950ad39243e813f929f21691c3698835f2784db8fd692ccd51R710-R722. I don't know whether that was deliberate or accidental.

I'll make a separate PR to resolve these issues, except for the last one, but I wanted to let y'all know.

— Reply to this email directly, view it on GitHub https://github.com/plone/plone.restapi/pull/1689#issuecomment-1691483769, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAL65X6VXDKFNFHAEFXF43XW4ZTDANCNFSM6AAAAAA335L6EI . You are receiving this because you commented.Message ID: <plone/plone. @.***>

stevepiercy commented 1 year ago

Ah, I see. That's... odd formatting.