search

plone / plone.restapi

RESTful API for Plone.
http://plonerestapi.readthedocs.org/
84 stars 73 forks source link

Formatting fixes for #1689 #1691

Closed stevepiercy closed 10 months ago

stevepiercy commented 10 months ago

Restores formatting and fixes some MyST syntax from #1689.

I am not sure whether to restore these deleted lines: https://github.com/plone/plone.restapi/pull/1689/files#diff-5181575a5b963d950ad39243e813f929f21691c3698835f2784db8fd692ccd51R710-R722 @tisto @davisagli please advise.

netlify[bot] commented 10 months ago

Deploy Preview for plone-restapi ready!

Name Link
Latest commit 2684887e05c6f59951d0ac475ff900330be48c83
Latest deploy log https://app.netlify.com/sites/plone-restapi/deploys/64e757d95c86d400087ff911
Deploy Preview https://deploy-preview-1691--plone-restapi.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mister-roboto commented 10 months ago

@stevepiercy thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

stevepiercy commented 10 months ago

@jenkins-plone-org please run jobs

stevepiercy commented 10 months ago

1693 needs to be merged to pass the failed workflow.