search

plone / plone.restapi

RESTful API for Plone.
http://plonerestapi.readthedocs.org/
84 stars 73 forks source link

Remove deprecated token parameter from vocabularies endpoint #1701

Closed tisto closed 9 months ago

mister-roboto commented 10 months ago

@tisto thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

netlify[bot] commented 10 months ago

Deploy Preview for plone-restapi canceled.

Name Link
Latest commit 26fc74edc8a75441cd597fa3ea8052b6604cd4ca
Latest deploy log https://app.netlify.com/sites/plone-restapi/deploys/650c914b7c9d9c0008cfdb83
tisto commented 10 months ago

@davisagli @sneridagh I removed the deprecated "token" parameter altogether in the PR now. I was wondering if we should return a 422 unprocessable entity (or something else) in case someone passes the "token" paramenter instead of "tokens". The idea would be to fail hard, so people notice it instead of just ignoring it (which might be hard to track).

The downside of this approach is that we have code that we might want to remove in plone.restapi 10 to clean up stuff. Opinions?

davisagli commented 10 months ago

-1 from me, this breaks volto as it currently uses this endpoint