plone / plone.restapi

RESTful API for Plone.
http://plonerestapi.readthedocs.org/
84 stars 75 forks source link

backport #1465: @site and @navroot endpoints #1702

Closed erral closed 11 months ago

erral commented 1 year ago

Backport of #1465 to 7.x.x to have it for https://github.com/plone/volto/pull/5185

mister-roboto commented 1 year ago

@erral thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

erral commented 1 year ago

@jenkins-plone-org please run jobs

erral commented 1 year ago

See: https://github.com/plone/volto/pull/5185

erral commented 1 year ago

eh... how are we testing the 7.x.x branch in python 2.7? It is not available on github actions... @plone/restapi-team

davisagli commented 1 year ago

@erral There is still a Jenkins job which tests on Python 2.7

tisto commented 1 year ago

@erral I remember that you can use an old ubuntu image on GHA that still ships with Python 2.7. Not sure if that still is the case though. It gets harder and harder to support Python 2.7 these days :(

erral commented 1 year ago

@erral There is still a Jenkins job which tests on Python 2.7

where all robot tests fail 😒

davisagli commented 11 months ago

@erral There are some syntax errors in Python 2

davisagli commented 11 months ago

@erral I think it would be fine to disable the new endpoints entirely for Plone 4.3 (i.e. with conditional zcml, plus skipping the tests on 4.3)

erral commented 11 months ago

@davisagli the whole point of this PR was to bring @site and @navroot to Plone 4.3 as per https://github.com/plone/volto/pull/5185#discussion_r1326497333

I will try to fix the issues.

davisagli commented 11 months ago

@erral Oops, right, I forgot. Carry on, then.

erral commented 11 months ago

@jenkins-plone-org please run jobs

erral commented 11 months ago

Green!

mauritsvanrees commented 8 months ago

I have released this in plone.restapi 7.9.0.