search

plone / plone.restapi

RESTful API for Plone.
http://plonerestapi.readthedocs.org/
84 stars 75 forks source link

Cleanup robot tests #1720

Closed gforcada closed 11 months ago

gforcada commented 12 months ago

It was not running for quite a long time ago already.

netlify[bot] commented 12 months ago

Deploy Preview for plone-restapi canceled.

Name Link
Latest commit 940512d1ab6bdb1871214fc0f168484cad9a3fc1
Latest deploy log https://app.netlify.com/sites/plone-restapi/deploys/652ad6daaa7cd2000844b369
mister-roboto commented 12 months ago

@gforcada thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

davisagli commented 11 months ago

@gforcada Tests are failing because there are still imports from plone.app.robotframework

gforcada commented 11 months ago

Actually not in plone.restapi but on plone.app.event and plone.app.contenttypes 😅

As this repository is still not plone/meta enabled, and it might take some time for it, at least parts of it, specially the testing part as this repo still supports Plone 5.2, it's a bit hard to fix.

We can keep the dependency here, to avoid the breakage, it does not feel clean, but at least works, hopefully 🍀

davisagli commented 11 months ago

@gforcada I'm trying it with plone.restapi's test extra depending on plone.app.contenttypes[test]

davisagli commented 11 months ago

@jenkins-plone-org please run jobs

tisto commented 11 months ago

@gforcada @davisagli did you folks run into this while trying Python 3.12 or rather the robotframework cleanup?

I just started a branch here:

https://github.com/plone/plone.restapi/pull/1722

and I was about to remove p.a.robotframework and friends because they cause trouble. I just want to avoid that we work on this at the same time...If that's the case I am happy to stop my efforts...

davisagli commented 11 months ago

@tisto I will merge this PR as soon as the jenkins builds finish.

gforcada commented 11 months ago

@davisagli thanks! 😄