search

plone / plone.restapi

RESTful API for Plone.
http://plonerestapi.readthedocs.org/
84 stars 73 forks source link

Remove debug-exceptions = on from the buildout instance section #1747

Closed wesleybl closed 4 months ago

wesleybl commented 4 months ago

This setting was causing validation errors to return BadRequest. This is different from a normal Plone installation.

It seems like it is a necessary configuration in performance tests. But we already have this configuration in the performance test buildout:

https://github.com/plone/plone.restapi/blob/366a9d0c61b1599032de275520e10c2a8a0925a6/plone-6.0.x-performance.cfg#L9

fixes #1734

netlify[bot] commented 4 months ago

Deploy Preview for plone-restapi canceled.

Name Link
Latest commit 263c49ed34441543a7e12166ea4a6a60d0a3df7d
Latest deploy log https://app.netlify.com/sites/plone-restapi/deploys/65c6260857dfaa00085d0e65
mister-roboto commented 4 months ago

@wesleybl thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!