search

plone / plone.restapi

RESTful API for Plone.
http://plonerestapi.readthedocs.org/
84 stars 73 forks source link

Fix serializer block with anchors, remove trailing slash before the anchor #1748

Closed sneridagh closed 4 months ago

sneridagh commented 4 months ago

@davisagli we overlooked this one :( the roundtrip was bugged because of the trailing slash. Please take a look at the regex, if it's fine like this.

netlify[bot] commented 4 months ago

Deploy Preview for plone-restapi canceled.

Name Link
Latest commit 2b6d47a65ed911838079753c806381c976fcfbac
Latest deploy log https://app.netlify.com/sites/plone-restapi/deploys/65ce77a045e60e00089d0f5b
mister-roboto commented 4 months ago

@sneridagh thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

sneridagh commented 4 months ago

@jenkins-plone-org please run jobs

davisagli commented 4 months ago

@jenkins-plone-org please run jobs

davisagli commented 4 months ago

I added a related fix for the deserializer too. Checking what jenkins says...

tisto commented 4 months ago

@davisagli @sneridagh released with https://pypi.org/project/plone.restapi/9.4.2/#section-1.