plone / plone.restapi

RESTful API for Plone.
http://plonerestapi.readthedocs.org/
84 stars 73 forks source link

Add the site timezone info to the @site endpoint #1749

Closed folix-01 closed 4 months ago

mister-roboto commented 4 months ago

@folix-01 thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

netlify[bot] commented 4 months ago

Deploy Preview for plone-restapi canceled.

Name Link
Latest commit 16bebb15b07bb3e314db5d3ee8f61c40b8b82f59
Latest deploy log https://app.netlify.com/sites/plone-restapi/deploys/65e3cc34efa88c0008a82cf5
folix-01 commented 4 months ago

@jensens @mauritsvanrees Hi, here I have the only test run that fails, it's the test for a python39. The problem is that the restapi response and the expected result have a different dictionary key-value order. I don’t really understand why it happens, any idea?

Screenshot 2024-02-16 at 17 27 48
wesleybl commented 4 months ago

@folix-01 did you run the tests locally and plone.site_timezone was Europe/Berlin in the resp file?

stevepiercy commented 4 months ago

@folix-01 the CI's error message is above your screenshot with what happened and how to solve it.

folix-01 commented 4 months ago

@folix-01 did you run the tests locally and plone.site_timezone was Europe/Berlin in the resp file?

I didn't run the tests locally so as I can't make a buildout

folix-01 commented 4 months ago

@jenkins-plone-org please run jobs

folix-01 commented 4 months ago

@jenkins-plone-org please run jobs

folix-01 commented 4 months ago

@erral @stevepiercy How is the contribution workflow working? Do I have to do the merge personally or wait the release manager to do it?

erral commented 4 months ago

nope, @tisto or @davisagli will look at it and merge

folix-01 commented 4 months ago

@jenkins-plone-org please run jobs

folix-01 commented 4 months ago

@jenkins-plone-org please run jobs

folix-01 commented 4 months ago

@jenkins-plone-org please run jobs