Closed folix-01 closed 4 months ago
Name | Link |
---|---|
Latest commit | 16bebb15b07bb3e314db5d3ee8f61c40b8b82f59 |
Latest deploy log | https://app.netlify.com/sites/plone-restapi/deploys/65e3cc34efa88c0008a82cf5 |
@jensens @mauritsvanrees Hi, here I have the only test run that fails, it's the test for a python39. The problem is that the restapi response and the expected result have a different dictionary key-value order. I don’t really understand why it happens, any idea?
@folix-01 did you run the tests locally and plone.site_timezone
was Europe/Berlin
in the resp file?
@folix-01 did you run the tests locally and
plone.site_timezone
wasEurope/Berlin
in the resp file?
I didn't run the tests locally so as I can't make a buildout
@jenkins-plone-org please run jobs
@jenkins-plone-org please run jobs
@erral @stevepiercy How is the contribution workflow working? Do I have to do the merge personally or wait the release manager to do it?
nope, @tisto or @davisagli will look at it and merge
@jenkins-plone-org please run jobs
@jenkins-plone-org please run jobs
@jenkins-plone-org please run jobs
@folix-01 thanks for creating this Pull Request and helping to improve Plone!
TL;DR: Finish pushing changes, pass all other checks, then paste a comment:
To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.
Happy hacking!