search

plone / plone.restapi

RESTful API for Plone.
http://plonerestapi.readthedocs.org/
84 stars 73 forks source link

Enhance Path Handling in Makefile #1753

Closed Vivek-04022001 closed 4 months ago

Vivek-04022001 commented 4 months ago

Issue Description:

The Makefile uses realpath to set SPHINXBUILD and SPHINXAUTOBUILD:

SPHINXBUILD     = $(realpath bin/sphinx-build)
SPHINXAUTOBUILD = $(realpath bin/sphinx-autobuild)

replace with 

SPHINXBUILD     = "$(realpath bin/sphinx-build)"
SPHINXAUTOBUILD = "$(realpath bin/sphinx-autobuild)"

This can cause compatibility issues and doesn't handle special characters in paths. We need to replace realpath with a more portable and robust method. This issues was already discussed with @stevepiercy on plone community conversation link

mister-roboto commented 4 months ago

@Vivek-04022001 thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

netlify[bot] commented 4 months ago

Deploy Preview for plone-restapi canceled.

Name Link
Latest commit 0bf22eacbcc94646010d7c6b3a01536b4602b4dd
Latest deploy log https://app.netlify.com/sites/plone-restapi/deploys/65d6348aa605eb00089b487c
stevepiercy commented 4 months ago

@mauritsvanrees @tisto @sneridagh is it OK for me to merge, or do you want to do that as maintainer?