search

plone / plone.restapi

RESTful API for Plone.
http://plonerestapi.readthedocs.org/
84 stars 73 forks source link

Fix test to work with the new way plone.rest returns errors #1755

Closed wesleybl closed 4 months ago

wesleybl commented 4 months ago

After:

https://github.com/plone/plone.rest/pull/179

BadRequest errors are returned as an object and not as a string. This fix here takes this into account. But for now the tests are skipped, so that the merge can be done before the plone.rest change is in a Plone version.

mister-roboto commented 4 months ago

@wesleybl thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

netlify[bot] commented 4 months ago

Deploy Preview for plone-restapi canceled.

Name Link
Latest commit 0025301bcdaac604e5609b57e7b0f48c63dd87f3
Latest deploy log https://app.netlify.com/sites/plone-restapi/deploys/65d8a1aea23aec0008a2a5a3
wesleybl commented 4 months ago

@jenkins-plone-org please run jobs

wesleybl commented 4 months ago

It may be that plone/plone.rest#179 is not necessary.

wesleybl commented 4 months ago

https://github.com/plone/plone.rest/pull/179 it was not necessary.