search

plone / plone.restapi

RESTful API for Plone.
http://plonerestapi.readthedocs.org/
84 stars 73 forks source link

Use the mode parameter instead of direction when calling the scale method #1758

Closed wesleybl closed 3 months ago

wesleybl commented 4 months ago

The direction parameter is deprecated. This avoids the warning:

DeprecationWarning: The 'direction' option is deprecated, use 'mode' instead.

Also change value to scale.

Even though we get the warning in Plone 5.2, the tests fail when we use mode. So we keep direction in Plone 5.2.

Ref: https://github.com/plone/Products.CMFPlone/issues/3850

mister-roboto commented 4 months ago

@wesleybl thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

netlify[bot] commented 4 months ago

Deploy Preview for plone-restapi canceled.

Name Link
Latest commit 65913e9de7a7e136bf12dabe1a57d1d148643cc8
Latest deploy log https://app.netlify.com/sites/plone-restapi/deploys/65e77875a249e1000832b6c7
wesleybl commented 4 months ago

@jenkins-plone-org please run jobs

wesleybl commented 3 months ago

@jenkins-plone-org please run jobs

wesleybl commented 3 months ago

@jenkins-plone-org please run jobs

wesleybl commented 3 months ago

@mauritsvanrees can you please take a look here?