plone / plone.restapi

RESTful API for Plone.
http://plonerestapi.readthedocs.org/
84 stars 73 forks source link

Bump all the versions in GitHub workflows #1762

Closed stevepiercy closed 3 months ago

stevepiercy commented 3 months ago

flake8 is not ready for Python 3.12, so it stays at 3.11 for now, unless another tool replaces it.

mister-roboto commented 3 months ago

@stevepiercy thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

netlify[bot] commented 3 months ago

Deploy Preview for plone-restapi canceled.

Name Link
Latest commit 528c20ce22f5883a27642d2087a2d15cdf1cfd55
Latest deploy log https://app.netlify.com/sites/plone-restapi/deploys/65f283e01bc193000892cb79
stevepiercy commented 3 months ago

@jenkins-plone-org please run jobs

jensens commented 3 months ago

As this was already before this PR the case its not about this PR: Having a matrix with just one Python version is ... pointless?

stevepiercy commented 3 months ago

@jensens please have another look. The matrix is preserved for tests, but not for things that only need to run once on a single version of Python, such as black, docs, and so on.

jensens commented 3 months ago

I.e. for black there is a matrix with one entry. It does not make much of a difference - so lets keep it -, but it is pointless.

screenshot_2024-03-14_18:18:04_selection

stevepiercy commented 3 months ago

Oh, I understand your point now. Well, maybe matrix is a poor choice of key, and env would be better. Either way, it allows to set it in one place and reuse it in multiple places.

I can change it to use env, if you prefer. Please let me know.