search

plone / plone.restapi

RESTful API for Plone.
http://plonerestapi.readthedocs.org/
84 stars 73 forks source link

In Plone 6, uses plone.textindexer to add block texts to the SearchableText index #1766

Closed wesleybl closed 3 months ago

wesleybl commented 3 months ago

This ensures that behaviors can add fields to SearchableText with plone.textindexer.

IBlocks now inherits from IDexterityTextIndexer, so there is no need to add the plone.textindexer behavior to the types to enable indexing. The content simply needs to have the IBlocks behavior.

fixes #1744

mister-roboto commented 3 months ago

@wesleybl thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

netlify[bot] commented 3 months ago

Deploy Preview for plone-restapi canceled.

Name Link
Latest commit 5afaa07e4d146b004c890fab893d21a3c6ef890c
Latest deploy log https://app.netlify.com/sites/plone-restapi/deploys/6608b18d71161c00089014fa
wesleybl commented 3 months ago

@jenkins-plone-org please run jobs

wesleybl commented 3 months ago

@jenkins-plone-org please run jobs

wesleybl commented 3 months ago

@davisagli is it necessary to remove the Plone Jenkins CI job - pull-request-6.1-3.8 from the repository configuration?

davisagli commented 3 months ago

@jenkins-plone-org please run jobs

wesleybl commented 3 months ago

I made a couple simplifications to the conditional imports -- see what you think.

@davisagli better. Thanks!