search

plone / plone.restapi

RESTful API for Plone.
http://plonerestapi.readthedocs.org/
84 stars 73 forks source link

image_scales in serializer are returned as json_compatible format #1772

Closed cekk closed 2 months ago

cekk commented 3 months ago

This lead to problems when for example we have a custom service that serialize some blocks and do not force a json_compatible formatting to the returned data.

I have a service that take some blocks, serialize them and return the result. But image_scales are a PersistentMapping instance and breaks json formatting.

For content-types serialization or other services like @search this is not a problem because there is something that force json compatibility.

mister-roboto commented 3 months ago

@cekk thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

netlify[bot] commented 3 months ago

Deploy Preview for plone-restapi canceled.

Name Link
Latest commit 586fbaa6dd7e3afd39d3d30411a1bdd062e5c78d
Latest deploy log https://app.netlify.com/sites/plone-restapi/deploys/660d18dc382fe40008efc143
cekk commented 3 months ago

@jenkins-plone-org please run jobs