search

plone / plone.restapi

RESTful API for Plone.
http://plonerestapi.readthedocs.org/
84 stars 73 forks source link

add cache rules for @site and @navroot #1779

Closed mamico closed 1 month ago

mamico commented 1 month ago

there are no caching rule for @site and @navroot.

Is it intentional omission or oversight?

mister-roboto commented 1 month ago

@mamico thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

netlify[bot] commented 1 month ago

Deploy Preview for plone-restapi canceled.

Name Link
Latest commit 1062d54171c31eba5806ad5bffb9c33c5bd00c7f
Latest deploy log https://app.netlify.com/sites/plone-restapi/deploys/663b3d492981df0009a5c8c9
erral commented 1 month ago

there are no caching rule for @site and @navroot.

Is it intentional omission or oversight?

It wasn't intentional at all.

mamico commented 1 month ago

@jenkins-plone-org please run jobs