search

plone / plone.restapi

RESTful API for Plone.
http://plonerestapi.readthedocs.org/
84 stars 73 forks source link

Make Teaser blocks dynamic #1788

Closed pbauer closed 2 weeks ago

pbauer commented 1 month ago

PLIP: https://github.com/plone/volto/issues/6023 Depends on https://github.com/plone/volto/pull/6024 but should not break anything without it.

mister-roboto commented 1 month ago

@pbauer thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

netlify[bot] commented 1 month ago

Deploy Preview for plone-restapi canceled.

Name Link
Latest commit 6f0dcbf33c4fb989c3f2ec642d979e6455271f98
Latest deploy log https://app.netlify.com/sites/plone-restapi/deploys/666a1210e955040008523ceb
sneridagh commented 1 month ago

@jenkins-plone-org please run jobs

sneridagh commented 1 month ago

@pbauer could you take care of Jens suggestion? @davisagli could you please take a look?

pbauer commented 3 weeks ago

@jenkins-plone-org please run jobs

davisagli commented 2 weeks ago

@jenkins-plone-org please run jobs

tisto commented 2 weeks ago

@pbauer @davisagli good work! Shall we make a release with this new feature?

I am wondering if a major release would make it easier for us to keep things in sync with the Volto 18 release which this feature will be shipped with, right @sneridagh?

sneridagh commented 2 weeks ago

Yes, the plan is to have it paired with 18 and 6.1. I'm ok with a major, up to you though.

We need a release asap, so we can have the Volto side merged. I plan to work on it during the sprint.

tisto commented 2 weeks ago

I gave this some thought and I will release a feature release. For "internal" packages it makes lots of sense to stick with strict semantic versioning.

tisto commented 2 weeks ago

@pbauer @davisagli @sneridagh FYI: I released this with p.restapi 9.7.0: https://pypi.org/project/plone.restapi/9.7.0/