search

plone / plone.staticresources

Static resources for Plone
https://pypi.org/project/plone.staticresources/
5 stars 13 forks source link

Upgrade Bootstrap to 5.1.1 #164

Closed petschki closed 3 years ago

mister-roboto commented 3 years ago

@petschki thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

petschki commented 3 years ago

@jenkins-plone-org please run jobs

petschki commented 3 years ago

@jenkins-plone-org please run jobs

petschki commented 3 years ago

@jenkins-plone-org please run jobs

petschki commented 3 years ago

@mauritsvanrees do you have any clue, why jenkins gets an error with this PR?

petschki commented 3 years ago

sorry... the upgrade profile wasn't hidden. fixed that.

petschki commented 3 years ago

@jenkins-plone-org please run jobs

mauritsvanrees commented 3 years ago

I get the same error locally with this branch, and not with master, so that helps:

$ bin/test -s Products.CMFPlone -t test_addons_controlpanel_install_and_uninstall_all
...
Failure in test test_addons_controlpanel_install_and_uninstall_all (Products.CMFPlone.controlpanel.tests.test_controlpanel_browser_installer.AddonsControlPanelFunctionalTest)
Traceback (most recent call last):
  File "/usr/local/Cellar/python@3.9/3.9.7/Frameworks/Python.framework/Versions/3.9/lib/python3.9/unittest/case.py", line 59, in testPartExecutor
    yield
  File "/usr/local/Cellar/python@3.9/3.9.7/Frameworks/Python.framework/Versions/3.9/lib/python3.9/unittest/case.py", line 592, in run
    self._callTestMethod(testMethod)
  File "/usr/local/Cellar/python@3.9/3.9.7/Frameworks/Python.framework/Versions/3.9/lib/python3.9/unittest/case.py", line 550, in _callTestMethod
    method()
  File "/Users/maurits/community/plone-coredev/6.0/src/Products.CMFPlone/Products/CMFPlone/controlpanel/tests/test_controlpanel_browser_installer.py", line 110, in test_addons_controlpanel_install_and_uninstall_all
    self.browser.getControl('Install', index=0)
  File "/usr/local/Cellar/python@3.9/3.9.7/Frameworks/Python.framework/Versions/3.9/lib/python3.9/unittest/case.py", line 226, in __exit__
    self._raiseFailure("{} not raised".format(exc_name))
  File "/usr/local/Cellar/python@3.9/3.9.7/Frameworks/Python.framework/Versions/3.9/lib/python3.9/unittest/case.py", line 163, in _raiseFailure
    raise self.test_case.failureException(msg)
AssertionError: LookupError not raised

The test sees there are three Install buttons for add-ons, it clicks on all of them, and then it checks that no Install buttons are left, so we expect a LookupError. On this branch there is an Install button left.

Ah, when I look at the browser contents, I see that with your branch there is an extra Install button, for "Update bundles" (plone.staticresources.upgrades). Probably clicking on it has no effect, or not the desired effect.

Ah, I see a new commit coming in, which seems to fix this. :-)

petschki commented 3 years ago

sry for the noise 🙈

mauritsvanrees commented 3 years ago

No problem. :-)