search

plone / plone.staticresources

Static resources for Plone
https://pypi.org/project/plone.staticresources/
5 stars 12 forks source link

Omit system paths in compiled js files #196

Closed pgrunewald closed 2 years ago

pgrunewald commented 2 years ago

Fixes #195

mister-roboto commented 2 years ago

@pgrunewald thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

petschki commented 2 years ago

this file isn't used in Plone 6 (=master branch) anymore. staticresources are build with webpack.

wesleybl commented 2 years ago

@pgrunewald you can do this on the 1.x branch, which is used in Plone 5.2.

@petschki If the file is no longer used, wouldn't it be better to remove it?

petschki commented 2 years ago

I have many cleanup tasks on my list for Buschenschanksprint in May 😉 ... stay tuned

petschki commented 2 years ago

note: the script has been removed recently: https://github.com/plone/plone.staticresources/commit/5b81392cfb760755a51e9ffb785271533bfd901d