search

plone / plone.staticresources

Static resources for Plone
https://pypi.org/project/plone.staticresources/
5 stars 12 forks source link

Fix icon font loading #207

Closed thet closed 2 years ago

thet commented 2 years ago

Fix issue with Glyphicons and Fontello font loading on Portals where the portal root is a level higher. The fonts are now loaded relative to the CSS requesting them.

Fixes: https://github.com/plone/plone.staticresources/issues/162 Fixes: https://github.com/plone/plone.staticresources/issues/203

Ref: https://github.com/plone/plone.staticresources/pull/168 Ref: https://github.com/plone/plone.staticresources/pull/171 Ref: https://github.com/plone/plone.staticresources/pull/175 Ref: https://community.plone.org/t/deployments-not-rooted-fail-to-load-the-fontello-icons/15047/12?u=thet

@sneridagh @agitator @yurj @cekk please review this PR if it fixes the font loading problem for you and for not introducing new errors.

mister-roboto commented 2 years ago

@thet thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

thet commented 2 years ago

@jenkins-plone-org please run jobs

thet commented 2 years ago

@mauritsvanrees are you planning a new Plone 5 release? This fix would be relevant...

mauritsvanrees commented 2 years ago

Thanks @thet!

Yes, I want to release Plone 5.2.8 in April, so this would be welcome.

erral commented 2 years ago

I have installed the 1.x branch in a client's site running Plone 5.2.7, and after running the upgrade step the icons are showing OK in both deployment scenarios (full domain and a path under the domain) and with debug mode on and off.

sneridagh commented 2 years ago

@mauritsvanrees could we have a release so we can apply it right away? It would be great! Thanks!