search

plone / plone.staticresources

Static resources for Plone
https://pypi.org/project/plone.staticresources/
5 stars 12 forks source link

Module federation #222

Closed thet closed 2 years ago

thet commented 2 years ago

Jenkins Parameter:

https://github.com/plone/plone.staticresources/pull/222
https://github.com/plone/Products.CMFPlone/pull/3539
mister-roboto commented 2 years ago

@thet thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

thet commented 2 years ago

@jenkins-plone-org please run jobs

thet commented 2 years ago

@petschki please try to rm -rf node_modules in mockup + any add-ons like mosaic and then again yarn install. Maybe you have the same issue as i faced that there is a backbone.paginator with it's own outdated version of backbone and underscore in it's own node_modules subfolder...

petschki commented 2 years ago

@jenkins-plone-org please run jobs