plone / plone.staticresources

Static resources for Plone
https://pypi.org/project/plone.staticresources/
5 stars 12 forks source link

Mockup 5a21 #243

Closed petschki closed 2 years ago

petschki commented 2 years ago

When running yarn run build with the latest mockup 5a21 I get the following webpack error:

yarn run v1.22.19
$ NODE_ENV=production webpack --config webpack.config.js
assets by status 4.2 MiB [cached] 2072 assets
runtime modules 4.25 KiB 7 modules
container entry 42 bytes [built] [code generated]

ERROR in container entry ./main[0]
Module not found: Error: Can't resolve 'babel-loader' in '/Users/peterm/workspace/buildout.coredev/src/plone.staticresources'
resolve 'babel-loader' in '/Users/peterm/workspace/buildout.coredev/src/plone.staticresources'
  Parsed request is a module
  using description file: /Users/peterm/workspace/buildout.coredev/src/plone.staticresources/package.json (relative path: .)
    resolve as module
      looking for modules in /Users/peterm/workspace/buildout.coredev/src/plone.staticresources/node_modules
        single file module
          using description file: /Users/peterm/workspace/buildout.coredev/src/plone.staticresources/package.json (relative path: ./node_modules/babel-loader)
            no extension
              /Users/peterm/workspace/buildout.coredev/src/plone.staticresources/node_modules/babel-loader doesn't exist
            .js
              /Users/peterm/workspace/buildout.coredev/src/plone.staticresources/node_modules/babel-loader.js doesn't exist
        /Users/peterm/workspace/buildout.coredev/src/plone.staticresources/node_modules/babel-loader doesn't exist
      /Users/peterm/workspace/buildout.coredev/src/node_modules doesn't exist or is not a directory
      /Users/peterm/workspace/buildout.coredev/node_modules doesn't exist or is not a directory
      looking for modules in /Users/peterm/workspace/node_modules
        single file module
          No description file found in /Users/peterm/workspace/node_modules or above
          no extension
            /Users/peterm/workspace/node_modules/babel-loader doesn't exist
          .js
            /Users/peterm/workspace/node_modules/babel-loader.js doesn't exist
        /Users/peterm/workspace/node_modules/babel-loader doesn't exist
      /Users/peterm/node_modules doesn't exist or is not a directory
      /Users/node_modules doesn't exist or is not a directory
      /node_modules doesn't exist or is not a directory

ERROR in bundle.min
Module not found: Error: Can't resolve 'babel-loader' in '/Users/peterm/workspace/buildout.coredev/src/plone.staticresources'
resolve 'babel-loader' in '/Users/peterm/workspace/buildout.coredev/src/plone.staticresources'
  Parsed request is a module
  using description file: /Users/peterm/workspace/buildout.coredev/src/plone.staticresources/package.json (relative path: .)
    resolve as module
      looking for modules in /Users/peterm/workspace/buildout.coredev/src/plone.staticresources/node_modules
        single file module
          using description file: /Users/peterm/workspace/buildout.coredev/src/plone.staticresources/package.json (relative path: ./node_modules/babel-loader)
            no extension
              /Users/peterm/workspace/buildout.coredev/src/plone.staticresources/node_modules/babel-loader doesn't exist
            .js
              /Users/peterm/workspace/buildout.coredev/src/plone.staticresources/node_modules/babel-loader.js doesn't exist
        /Users/peterm/workspace/buildout.coredev/src/plone.staticresources/node_modules/babel-loader doesn't exist
      /Users/peterm/workspace/buildout.coredev/src/node_modules doesn't exist or is not a directory
      /Users/peterm/workspace/buildout.coredev/node_modules doesn't exist or is not a directory
      looking for modules in /Users/peterm/workspace/node_modules
        single file module
          No description file found in /Users/peterm/workspace/node_modules or above
          no extension
            /Users/peterm/workspace/node_modules/babel-loader doesn't exist
          .js
            /Users/peterm/workspace/node_modules/babel-loader.js doesn't exist
        /Users/peterm/workspace/node_modules/babel-loader doesn't exist
      /Users/peterm/node_modules doesn't exist or is not a directory
      /Users/node_modules doesn't exist or is not a directory
      /node_modules doesn't exist or is not a directory

webpack 5.73.0 compiled with 2 errors in 810 ms
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

@thet do you have any advice how to solve this? until now we didn't have to do anything with babel-loader ... is it now needed in the devDependencies?

mister-roboto commented 2 years ago

@petschki thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

thet commented 2 years ago

@jenkins-plone-org please run jobs