search

plone / plone.staticresources

Static resources for Plone
https://pypi.org/project/plone.staticresources/
4 stars 12 forks source link

Use successor repository of `svg-country-flags` #248

Closed petschki closed 1 year ago

mister-roboto commented 1 year ago

@petschki thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

petschki commented 1 year ago

@jenkins-plone-org please run jobs

jensens commented 1 year ago

still draft? LGTM so far.

petschki commented 1 year ago

The "Netherlands Antilles" got deleted somehow in this repo ... as long as its not critical to us we can merge it. I wanted to file an issue there and see whats the response.

petschki commented 1 year ago

ok, found this issue there: https://github.com/hampusborgos/country-flags/issues/54 ... explanation why removed.