search

plone / plone.staticresources

Static resources for Plone
https://pypi.org/project/plone.staticresources/
5 stars 12 forks source link

Upgrade #259

Closed thet closed 1 year ago

thet commented 1 year ago

Together: https://github.com/plone/plone.staticresources/pull/259 https://github.com/plone/plone.app.dexterity/pull/358

mister-roboto commented 1 year ago

@thet thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

thet commented 1 year ago

@jenkins-plone-org please run jobs

thet commented 1 year ago

@jenkins-plone-org please run jobs

petschki commented 1 year ago

Somehow the customplugins plonelink and ploneimage aren't ~in the tinymce config~ loading correctly anymore. Thats why Jenkins is broken. I'll check why and try to fix.

petschki commented 1 year ago

@jenkins-plone-org please run jobs

petschki commented 1 year ago

@frapell @thet missing tinymce plugins should be fixed now.

petschki commented 1 year ago

@mauritsvanrees I've fixed the news snipped. Upgrade step is not needed as there are no registry changes.

petschki commented 1 year ago

@jenkins-plone-org please run jobs

mauritsvanrees commented 1 year ago

@mauritsvanrees I've fixed the news snipped. Upgrade step is not needed as there are no registry changes.

Ah, right, updating the timestamp manually is not needed anymore I think. I am still not completely clear on when an upgrade step is needed now. There might be documentation I need to read. :-)

thet commented 1 year ago

@mauritsvanrees The modeleditor PR test failures were fixed by this merge. The modeleditor structure change needed this new mockup version... There is a new pat-code-editor which should work better than the previous one (using Highlight.JS to for syntax highlighting allows to highlight while typing, now also the line-numbers should work, and so on)

@petschki @mauritsvanrees thanks for finishing both PRs!