plone / plone.staticresources

Static resources for Plone
https://pypi.org/project/plone.staticresources/
4 stars 12 forks source link

Mockup update #280

Closed petschki closed 1 year ago

mister-roboto commented 1 year ago

@petschki thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

petschki commented 1 year ago

@jenkins-plone-org please run jobs

petschki commented 1 year ago

@plone/ci-team would you be so kind and activate GHA for this repository?

davisagli commented 1 year ago

@petschki What do you mean exactly? There's no activation needed for GHA, you activate it by adding files in .github/workflows to define the workflows you want to run.

petschki commented 1 year ago

@davisagli since configuring with plone/meta the activation has to be done manually, because the config files lying there. I do not know exactly the workflow but this is how its was done in plonetheme.barceloneta too by @jensens ... @gforcada or @mauritsvanrees might have more insights on this too ...

davisagli commented 1 year ago

I see, the request was for activating plone/meta, not GHA in general.

mauritsvanrees commented 1 year ago

@petschki Done.