search

plone / plone.staticresources

Static resources for Plone
https://pypi.org/project/plone.staticresources/
4 stars 12 forks source link

Reconfiguring with plone/meta, try fixing ModuleNotFoundError #284

Closed mauritsvanrees closed 1 year ago

mauritsvanrees commented 1 year ago

Hardly a difference anymore, but this is to check why tox -e test fails:

Module: src.plone.staticresources.tests.test_setup

ModuleNotFoundError: No module named 'src'

See for example this gh-actions run: https://github.com/plone/plone.staticresources/actions/runs/4777441477/jobs/8493176778?pr=283

mauritsvanrees commented 1 year ago

@gforcada I guess this fails somehow because there is a src directory. Do we need to change anything in the tox or other config files for this to work?

gforcada commented 1 year ago

Yes, the zope-testrunner line needs a little adjustment... I've been slacking off from doing that on plone/meta and simply patch it manually every time I noticed the src folder 😅

There are only a handful packages yet to be converted to plone/meta, but since the first version, we have updated it quite a bit, so my rough plan was to finish these first few packages, and then go through all packages again, and keep fixing the small annoyances (like this one) to have a perfectly defined plone/meta ✨

We can, of course, start doing that clean up now rather than later 😅

petschki commented 1 year ago

Thanks @gforcada . I've reconfigured this PR here https://github.com/plone/plone.staticresources/pull/283 as you did and close this one.