introspect the real reason behind PR #13

plone / plone.supermodel

Provides XML import and export for schema interfaces based on zope.schema fields

5 stars 8 forks source link

introspect the real reason behind PR #13 #14

Open jensens opened 8 years ago

jensens commented 8 years ago

see #13

by @pbauer:

plone.dexterity.schema.generated.plone_0_LockableType has zope.interface.adapter.VerifyingAdapterLookup as a dependent which again has no dependents.

Maybe VerifyingAdapterLookup should not be here or it should have dependents (a weakref.WeakKeyDictionary())
Maybe also related to the comment below which states that the first base class of a schema must be a SchemaClass.

ale-rt commented 3 years ago

The patch introduyced in #13 was removed in https://github.com/plone/plone.supermodel/commit/c1822bb822270b323558bfd3cd49229c50b04140 But we have no clue why it became not necessary anymore

jensens commented 3 years ago

This "esoteric code" (tm) is all for the sake of testing if the directives are correct AFAICT. Question is if this is can be achieved different, with that much boilerplate code.