search

plone / plone.supermodel

Provides XML import and export for schema interfaces based on zope.schema fields
5 stars 8 forks source link

Add support for Python3 #21

Closed pbauer closed 6 years ago

pbauer commented 7 years ago

The tests only run together with https://github.com/plone/plone.rfc822/pull/4 We tried not to use six but are open to any suggestions.

pbauer commented 7 years ago

@mister-roboto you are lying, you evil robot overlord. @dhavlik signed the CA and sent it in.

gforcada commented 7 years ago

(in behalf of mr.roboto)

@pbauer no, mr.roboto is not lying! See it by yourself:

https://api.github.com/repos/plone/plone.supermodel/commits/e2aa2add70c4e01e61df5acebd019461b5f796d0

https://api.github.com/repos/plone/plone.supermodel/commits/d274c5c3893af0f4e3dbf7e13ef2a7f2f88c07cb

The two commits made by @dhavlik are not using any email (as mr.roboto complains) that @dhavlik has on github. That should be updated.

You can clearly recognize that seeing that there is the octopus icon rather than @dhavlik avatar on the commits list: https://github.com/plone/plone.supermodel/pull/21/commits

pbauer commented 7 years ago

true and wise, oh great robot!

gforcada commented 7 years ago

@pbauer if you merge this or other pull requests adding support to python 3, would you mind creating an issue on buildout.coredev so that the py3 buildout configuration for the jenkins job gets updated as well?

davilima6 commented 6 years ago

Current failure is related to indentation.

Also needs rebasing master.

davilima6 commented 6 years ago

@pbauer, @mauritsvanrees: tests pass for Python 2 but still not for 3.

There's one commented line that must be removed in plone/supermodel/__init__.py but I think it's time for a review before I go on, in order to check I'm going in the right direction, or forcing some serialisation step too early (I suspect that's what I might be doing wrong for Py3 tests).

jensens commented 6 years ago

I fixed @dhavlik email address (was something with .local) by interactive rebase.

For future commits, please use the email addresses known by Github (you can add more at your profile page)