search

plone / plone.supermodel

Provides XML import and export for schema interfaces based on zope.schema fields
5 stars 8 forks source link

Dx siteroot #27

Closed jaroel closed 3 years ago

mister-roboto commented 5 years ago

@jaroel thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

jensens commented 4 years ago

@jaroel This change could be merged even w/o dx-site-root. It needs a Changelog entry and tests run.

jaroel commented 4 years ago

This whole thing can/should be revisited. The latter part of finalizeSchemas is a workaround for Python2 where isintance doesn't work as expected with InterfaceClasses, see https://github.com/zopefoundation/zope.interface/issues/16. This does work for Python3.

mister-roboto commented 3 years ago

@jaroel thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

mister-roboto commented 3 years ago

@jaroel thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

mauritsvanrees commented 3 years ago

I closed and reopened the PR, to see if that would get rid of the proposed Jenkins runs on 5.2, but that is not the case. Let's see what happens when we say:

@jenkins-plone-org please run jobs

jensens commented 3 years ago

Plone 5.2 coredev is on branch 1.x, so this is fine to merge.