search

plone / plone.supermodel

Provides XML import and export for schema interfaces based on zope.schema fields
5 stars 8 forks source link

support zope.interface 5.x+ with deferred _v_attrs dict creation #33

Closed jensens closed 4 years ago

jensens commented 4 years ago

Current zope.interface master, upcoming v5.0, create initializes _v_attrs with None to save memory and creates the dict upon first usage. So we need to do so in order to support the new version.

mister-roboto commented 4 years ago

@jensens thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

jensens commented 4 years ago

@jenkins-plone-org please run jobs

jensens commented 4 years ago

@jenkins-plone-org please run jobs

jensens commented 4 years ago

@jenkins-plone-org please run jobs