Closed gforcada closed 1 year ago
I was adding support for https://github.com/plone/meta to this repository and I did run tox -e format and tox -e lint on it.
tox -e format
tox -e lint
To my surprise flake8 raised:
flake8
plone/supermodel/utils.py:132:30: F821 undefined name 'IVocabularyFactory'
And indeed, IVocabularyFactory is used but not imported 😱
IVocabularyFactory
Seems that a WIP commit remove it 😅
What's more problematic than that, is that we never noticed it because it is wrapped in a quite worrisome bare try/except (which of course flake8 complains about it 😄 ).
try/except
I was adding support for https://github.com/plone/meta to this repository and I did run
tox -e formatandtox -e linton it.To my surprise
flake8raised:And indeed,
IVocabularyFactoryis used but not imported 😱Seems that a WIP commit remove it 😅
What's more problematic than that, is that we never noticed it because it is wrapped in a quite worrisome bare
try/except(which of courseflake8complains about it 😄 ).