search

plone / plone.supermodel

Provides XML import and export for schema interfaces based on zope.schema fields
5 stars 8 forks source link

Config with default template #46

Closed gforcada closed 1 year ago

gforcada commented 1 year ago

Locally a few tests do fail, a bit weird though 🤔

mister-roboto commented 1 year ago

@gforcada thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

gforcada commented 1 year ago

If we add Zope as a dependency, then tests do run, so there is some intermediate dependency that is needed, but not used directly by plone.supermodel 🤔

gforcada commented 1 year ago

Found it! 🎉 For whatever reason zope.testing is not directly required by plone.supermodel but it is needed. Fortunately depending on zope.configuration test extra makes all work 🍀