search

plone / plone.supermodel

Provides XML import and export for schema interfaces based on zope.schema fields
5 stars 8 forks source link

Fix parsing of empty Choice term, explicit term construction, support terms with title!=value, new tests #7

Closed seanupton closed 10 years ago

seanupton commented 10 years ago

See changelog.

This should, in theory, fix https://github.com/plone/plone.app.dexterity/issues/49

It also should enable folks who want to serialize and parse schemas containing Choice fields that have vocabulary terms with term.title != term.value.

Added numerous tests for ChoiceHandler (new) and additional doctest scenario for the new feature.

seanupton commented 10 years ago

@tdesvenain considering recent conversation on Dexterity dev list on the subject of vocabulary terms with identifiers/values distinct from titles, you might be interested in reviewing this pull request (I would appreciate any feedback).

@davisagli This should solve https://github.com/plone/plone.app.dexterity/issues/49 without the issues that you identified a long while back in (closed, unmerged) https://github.com/plone/plone.schemaeditor/pull/5